flashblocks: ensure cached stateroot is used even when hash validation comes from new_canonical_block notification#5
Merged
Conversation
…n comes from new_canonical_block notification
maoueh
approved these changes
May 29, 2026
| @@ -1167,12 +1198,30 @@ where | |||
| } | |||
| let stored_clone = state.stored_flashblocks.clone(); | |||
There was a problem hiding this comment.
No need for clone, can be pass by reference directly.
Comment on lines
+1201
to
+1217
| // No bundle-changing work has happened since the last flashblock | ||
| // execution, so the live revision is the one the speculative | ||
| // precompute (if any) was launched against. A hit skips the slow | ||
| // synchronous state_root and is the key to beating reth's full-block | ||
| // FIRE BLOCK out the door. | ||
| let cached_state_root = Self::cached_state_root_for( | ||
| &state, | ||
| canonical_block_number, | ||
| state.bundle_revision, | ||
| ); | ||
| if cached_state_root.is_some() { | ||
| debug!( | ||
| block = canonical_block_number, | ||
| revision = state.bundle_revision, | ||
| "canonical-driven is_final: using speculatively-precomputed state_root" | ||
| ); | ||
| } |
There was a problem hiding this comment.
Should we move that inside emission directly? Would be easier to see that block number is correct. checked for alignment if call was done later, no big deal though, I leave the decision to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.